The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.nongnu.pulsefire.device.ui.JNimbusColorFrame$ColorSetting.colorModel | PERFORMANCE | URF_UNREAD_FIELD | 224 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Primitive value is boxed and then immediately unboxed in org.nongnu.pulsefire.device.ui.JTopPanelSerial.deviceConnect() | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED | 161 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Potentially dangerous use of non-short-circuit logic in org.nongnu.pulsefire.device.ui.PulseFireTimeData.deviceConnect() | STYLE | NS_DANGEROUS_NON_SHORT_CIRCUIT | 124 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.nongnu.pulsefire.device.ui.PulseFireTimeData$TimeData be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 107 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.nongnu.pulsefire.device.ui.PulseFireTimeData$TimeDataKey be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 99 | Medium |
| Unread field: org.nongnu.pulsefire.device.ui.PulseFireTimeData$TimeDataKey.name | PERFORMANCE | URF_UNREAD_FIELD | 66 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.nongnu.pulsefire.device.ui.PulseFireUI.initialize(String[]) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 265 | Medium |
| org.nongnu.pulsefire.device.ui.PulseFireUI.startup() invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 300 | Medium |
| Exception is caught when Exception is not thrown in org.nongnu.pulsefire.device.ui.PulseFireUI.setupBuildInfo() | STYLE | REC_CATCH_EXCEPTION | 172 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.nongnu.pulsefire.device.ui.PulseFireUISettingManager.getSettingBoolean(PulseFireUISettingKeys) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 78 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.nongnu.pulsefire.device.ui.components.JCommandComboBox.actionPerformed(ActionEvent) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 74 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Suspicious comparison of Integer references in org.nongnu.pulsefire.device.ui.components.JCommandDial.commandReceived(Command) | CORRECTNESS | RC_REF_COMPARISON | 102 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.nongnu.pulsefire.device.ui.components.JConnectDialog(JFrame, String) invokes org.nongnu.pulsefire.device.ui.components.JConnectDialog$ConnectThread.start() | MT_CORRECTNESS | SC_START_IN_CTOR | 78 | Medium |
| new org.nongnu.pulsefire.device.ui.components.JConnectDialog(JFrame, String) invokes org.nongnu.pulsefire.device.ui.components.JConnectDialog$UpdateProgressThread.start() | MT_CORRECTNESS | SC_START_IN_CTOR | 77 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| integral division result cast to double or float in org.nongnu.pulsefire.device.ui.components.JFireBorder.paintBorder(Component, Graphics, int, int, int, int) | STYLE | ICAST_IDIV_CAST_TO_DOUBLE | 96 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| integral division result cast to double or float in org.nongnu.pulsefire.device.ui.components.JFireDial.paintComponent(Graphics) | STYLE | ICAST_IDIV_CAST_TO_DOUBLE | 183 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.nongnu.pulsefire.device.ui.components.JFireDial$DialEvent be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 299 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| integral division result cast to double or float in org.nongnu.pulsefire.device.ui.components.JFireGraph.paintComponent(Graphics) | STYLE | ICAST_IDIV_CAST_TO_DOUBLE | 140 | Medium |
| Unread field: org.nongnu.pulsefire.device.ui.components.JFireGraph.PAD; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 54 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Potentially dangerous use of non-short-circuit logic in org.nongnu.pulsefire.device.ui.components.JFireQMapTable$DeviceConfigVariableTableModel.isCellEditable(int, int) | STYLE | NS_DANGEROUS_NON_SHORT_CIRCUIT | 195 | High |
| Should org.nongnu.pulsefire.device.ui.components.JFireQMapTable$DeviceConfigVariableTableModel be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 116 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.nongnu.pulsefire.device.ui.components.JFireQMapTable$IntegerDocumentFilter be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 292 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.nongnu.pulsefire.device.ui.components.JFireQMapTable$MapVariableIdInputCellEditor be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 368 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.nongnu.pulsefire.device.ui.components.JFireQMapTable$MapVariableIdInputCellRenderer be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 322 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Potentially dangerous use of non-short-circuit logic in org.nongnu.pulsefire.device.ui.components.JFireQMapTable$MapVariableIdxInputCellEditor.getTableCellEditorComponent(JTable, Object, boolean, int, int) | STYLE | NS_DANGEROUS_NON_SHORT_CIRCUIT | 446 | High |
| Should org.nongnu.pulsefire.device.ui.components.JFireQMapTable$MapVariableIdxInputCellEditor be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 435 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.nongnu.pulsefire.device.ui.components.JFlashDialog$BuildOption be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 640 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.nongnu.pulsefire.device.ui.components.JIntegerTextField$DigitTextDocument be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 74 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.nongnu.pulsefire.device.ui.components.JMalEditor$LineCodeCellRenderer be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 333 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.nongnu.pulsefire.device.ui.tabs.JTabPanelLpm$LpmCommandStep be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 1066 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.nongnu.pulsefire.device.ui.tabs.JTabPanelLpm$LpmTuneResult.getDate() may expose internal representation by returning JTabPanelLpm$LpmTuneResult.date | MALICIOUS_CODE | EI_EXPOSE_REP | 463 | Medium |
| org.nongnu.pulsefire.device.ui.tabs.JTabPanelLpm$LpmTuneResult.setDate(Date) may expose internal representation by storing an externally mutable object into JTabPanelLpm$LpmTuneResult.date | MALICIOUS_CODE | EI_EXPOSE_REP2 | 469 | Medium |
| Should org.nongnu.pulsefire.device.ui.tabs.JTabPanelLpm$LpmTuneResult be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 451 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.nongnu.pulsefire.device.ui.tabs.JTabPanelLpm$LpmTuneStep be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 343 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.nongnu.pulsefire.device.ui.tabs.JTabPanelLpm$LpmTuneStepTableModel be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 524 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.nongnu.pulsefire.device.ui.tabs.JTabPanelLpm$LpmTuneStepTableModel$1.compare(JTabPanelLpm$LpmTuneStep, JTabPanelLpm$LpmTuneStep) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 535 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Potentially dangerous use of non-short-circuit logic in org.nongnu.pulsefire.device.ui.tabs.JTabPanelLpm$TriggerFire.run() | STYLE | NS_DANGEROUS_NON_SHORT_CIRCUIT | 1147 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Primitive value is boxed then unboxed to perform primitive coercion in org.nongnu.pulsefire.device.ui.tabs.JTabPanelMal.actionPerformed(ActionEvent) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 157 | Medium |
| Null pointer dereference of System.out in org.nongnu.pulsefire.device.ui.tabs.JTabPanelMal.actionPerformed(ActionEvent) | CORRECTNESS | NP_ALWAYS_NULL | 153 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| integral division result cast to double or float in org.nongnu.pulsefire.device.ui.tabs.JTabPanelScope$JScopePanel.createWaveForm(byte[]) | STYLE | ICAST_IDIV_CAST_TO_DOUBLE | 378 | Medium |
| org.nongnu.pulsefire.device.ui.tabs.JTabPanelScope$JScopePanel.createWaveForm(byte[]) ignores result of javax.sound.sampled.AudioInputStream.read(byte[]) | BAD_PRACTICE | RR_NOT_CHECKED | 323 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.nongnu.pulsefire.device.ui.tabs.JTabPanelScope$ScopeDataChannel be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 163 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dereference of the result of readLine() without nullcheck in org.nongnu.pulsefire.device.ui.tabs.JTabPanelSystem.readConfig(InputStream) | STYLE | NP_DEREFERENCE_OF_READLINE_VALUE | 240 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.nongnu.pulsefire.device.ui.tabs.JTabPanelSystem$ChipConfigFileFilter be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 176 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Potentially dangerous use of non-short-circuit logic in org.nongnu.pulsefire.device.ui.tabs.JTabPanelVariables$DeviceConfigVariableTableModel.getFilteredCommandMap(CommandVariableType) | STYLE | NS_DANGEROUS_NON_SHORT_CIRCUIT | 220 | High |
| Method org.nongnu.pulsefire.device.ui.tabs.JTabPanelVariables$DeviceConfigVariableTableModel.getFilteredCommandMap(CommandVariableType) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 212 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.nongnu.pulsefire.device.ui.time.EventTimeThread.run() | STYLE | REC_CATCH_EXCEPTION | 73 | Medium |